lkml.org 
[lkml]   [2012]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 2/5] kbuild: silence rule for extra_certificates
Added David and Rusty.

On Sun, Nov 18, 2012 at 03:05:14PM -0500, pefoley2@verizon.net wrote:
> From: Peter Foley <pefoley2@verizon.net>
>
> Silence the touch extra_certificates command
>
> Signed-off-by: Peter Foley <pefoley2@verizon.net>

I think we should tell the user that the default empty extra
certificates list is being used, in case the user used a wrong filename
or similar. How about this?

Subject: MODSIGN: Fix kbuild output when using default extra_certificates

Signed-off-by: Michal Marek <mmarek@suse.cz>

diff --git a/kernel/Makefile b/kernel/Makefile
index 0dfeca4..8c708e4 100644
--- a/kernel/Makefile
+++ b/kernel/Makefile
@@ -136,8 +136,12 @@ ifeq ($(CONFIG_MODULE_SIG),y)
#
# Pull the signing certificate and any extra certificates into the kernel
#
+
+quiet_cmd_touch = TOUCH $@
+ cmd_touch = touch $@
+
extra_certificates:
- touch $@
+ $(call cmd,touch)

kernel/modsign_pubkey.o: signing_key.x509 extra_certificates

But I don't insist on the above, feel free to hide the command
completely.
Michal

> ---
> kernel/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 86e3285..18a0b61 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -137,7 +137,7 @@ ifeq ($(CONFIG_MODULE_SIG),y)
> # Pull the signing certificate and any extra certificates into the kernel
> #
> extra_certificates:
> - touch $@
> + @touch $@
>
> kernel/modsign_pubkey.o: signing_key.x509 extra_certificates
>
> --
> 1.8.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html


\
 
 \ /
  Last update: 2012-12-09 18:21    [W:0.079 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site