Messages in this thread | | | Date | Sun, 09 Dec 2012 17:35:37 +0100 | From | Michal Marek <> | Subject | Re: [PATCH 3/5] add eboot.o and efi_stub_$(BITS).o to $(targets) |
| |
Added x86@kernel.org.
On 18.11.2012 21:05, pefoley2@verizon.net wrote: > From: Peter Foley <pefoley2@verizon.net> > > eboot.o and efi_stub_$(BITS).o are not in $(targets) so they are rebuilt > every time make is invoked. Add them to $(targets) to prevent unnecessary > rebuilding of bzImage. > > Signed-off-by: Peter Foley <pefoley2@verizon.net>
Acked-by: Michal Marek <mmarek@suse.cz>
BTW, it might be a good idea to split the $(targets) assignment into multiple lines.
Michal
> --- > arch/x86/boot/compressed/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile > index 8a84501..9d7a898 100644 > --- a/arch/x86/boot/compressed/Makefile > +++ b/arch/x86/boot/compressed/Makefile > @@ -4,7 +4,7 @@ > # create a compressed vmlinux image from the original vmlinux > # > > -targets := vmlinux.lds vmlinux vmlinux.bin vmlinux.bin.gz vmlinux.bin.bz2 vmlinux.bin.lzma vmlinux.bin.xz vmlinux.bin.lzo head_$(BITS).o misc.o string.o cmdline.o early_serial_console.o piggy.o > +targets := vmlinux.lds vmlinux vmlinux.bin vmlinux.bin.gz vmlinux.bin.bz2 vmlinux.bin.lzma vmlinux.bin.xz vmlinux.bin.lzo head_$(BITS).o misc.o string.o cmdline.o early_serial_console.o piggy.o eboot.o efi_stub_$(BITS).o > > KBUILD_CFLAGS := -m$(BITS) -D__KERNEL__ $(LINUX_INCLUDE) -O2 > KBUILD_CFLAGS += -fno-strict-aliasing -fPIC >
| |