Messages in this thread | | | From | "Kim, Milo" <> | Subject | RE: [PATCH 1/2] regulator: lp8788-buck: Remove val array in lp8788_init_dvs | Date | Mon, 10 Dec 2012 02:27:13 +0000 |
| |
> All elements of val array are zero. > Simply set data argument to be 0 in lp8788_update_bits call and remove > the val > array. > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
Axel, sorry I disagree with this patch because DVS_PIN is meaningful. In this case, explicit bit description is more important than code simplicity. So I would keep it.
Thanks, Milo
| |