Messages in this thread | | | Date | Sat, 8 Dec 2012 08:36:34 +0100 | From | Andreas Mohr <> | Subject | Re: Look Ma, da kernel is b0rken |
| |
Hi,
On Fri, Dec 07, 2012 at 06:44:05PM +0100, Borislav Petkov wrote: > On Fri, Dec 07, 2012 at 05:52:18PM +0100, Andreas Mohr wrote: > > Hmm, anyone deeply familiar with ISA PnP ID magic? :) > > Even if this is violating the ACPI spec, any fix for this needs to be > tested on the hardware (and I can very well imagine that the hardware > might be violating the spec too, nothing new here). > > So even if you had a fix, you need to run it on the hardware to verify > that it actually works.
And that demand actually applies to both the '@' change (questionable) and the much less disputed (obviously correct) wrong conditional fixup, since both introduce a notable change (either large, or possibly improper) in behaviour.
> So the actual practical question turns into: do you have such hardware > to verify your or anyone else's fix on?
Not the ALS100 (only ALS4000 here). I possibly have some other ISA hardware, but probably none which contains '@' data in their PnP id struct. The driver for the well-known case of ISDN PnP cards does not seem to contain it. However ISTR that CMI8330 was quite widespread (did I have one? Do I??). For identification, see http://www.yjfy.com/C/C-Media/soundchipset/CMI8330A.htm
I'm afraid I should get an old system back up and running, exactly for such validation work cases (and perhaps so should a select few other developers, too).
BTW, "my" fix? I thought that everybody had come to the conclusion by now that I merely pointed out (in no uncertain terms to boot) that something was broken :)
Andreas Mohr
| |