Messages in this thread | | | Date | Thu, 06 Dec 2012 21:16:08 +0300 | From | Sergei Shtylyov <> | Subject | Re: [v2 PATCH 6/8] watchdog/at91sam9_wdt: Use module_platform_driver() |
| |
Hello.
On 12/05/2012 04:34 AM, Wenyou Yang wrote:
> Using module_platform_driver() replaces module_init() and module_exit() > and makes the code simpler.
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> > Cc: wim@iguana.be > Cc: linux-watchdog@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/watchdog/at91sam9_wdt.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c > index 5afd3fb..a7c0881 100644 > --- a/drivers/watchdog/at91sam9_wdt.c > +++ b/drivers/watchdog/at91sam9_wdt.c > @@ -278,6 +278,7 @@ MODULE_DEVICE_TABLE(of, at91_wdt_dt_ids); > #endif > > static struct platform_driver at91wdt_driver = { > + .probe = at91wdt_probe,
You also need to remove '__init' annotation from that function since the driver becomes hot-plug aware now.
WBR, Sergei
| |