lkml.org 
[lkml]   [2012]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 02/11] Dove: Fix irq_to_pmu()
    Date
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Russell King - ARM Linux <linux@arm.linux.org.uk>

    commit d356cf5a74afa32b40decca3c9dd88bc3cd63eb5 upstream.

    PMU interrupts start at IRQ_DOVE_PMU_START, not IRQ_DOVE_PMU_START + 1.
    Fix the condition. (It may have been less likely to occur had the code
    been written "if (irq >= IRQ_DOVE_PMU_START" which imho is the easier
    to understand notation, and matches the normal way of thinking about
    these things.)

    Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
    Signed-off-by: Jason Cooper <jason@lakedaemon.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/arm/mach-dove/include/mach/pm.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/arm/mach-dove/include/mach/pm.h
    +++ b/arch/arm/mach-dove/include/mach/pm.h
    @@ -45,7 +45,7 @@ static inline int pmu_to_irq(int pin)

    static inline int irq_to_pmu(int irq)
    {
    - if (IRQ_DOVE_PMU_START < irq && irq < NR_IRQS)
    + if (IRQ_DOVE_PMU_START <= irq && irq < NR_IRQS)
    return irq - IRQ_DOVE_PMU_START;

    return -EINVAL;



    \
     
     \ /
      Last update: 2012-12-07 06:01    [W:3.119 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site