lkml.org 
[lkml]   [2012]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] spi: make sure all transfer has bits_per_word set
Date
On Mon, 12 Nov 2012 11:03:56 +0100, Jonas Gorski <jonas.gorski@gmail.com> wrote:
> Hi,
>
> On 9 November 2012 10:06, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> > When spi client does the spi transfer and does not sets
> > the bits_per_word for each transfer then set it as default
> > of spi device in spi core before calling low level transfer.
>
> I like that (not that it counts ... )!
>
> > Removing the similar code from spi-tegra20-slink driver as
> > it is not required.
>
> Not sure if this should be part of *this* patch.
> Also spi-tegra20-slink isn't the only one fixing up the bits_per_word
> for transfers, so it would be nice if you could remove it from the
> other drivers, too.
>
> In a future patch, maybe even do the same with speed_hz?

That sounds reasonable. Could you craft one up and see how it looks?

Thanks,
g.



\
 
 \ /
  Last update: 2012-12-07 01:01    [W:0.062 / U:0.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site