Messages in this thread | | | From | Bjorn Helgaas <> | Date | Thu, 6 Dec 2012 14:27:06 -0700 | Subject | Re: Sharing PCIE driver between Microblaze and Arm zynq |
| |
[+cc linux-pci]
On Thu, Dec 6, 2012 at 7:23 AM, Michal Simek <michal.simek@xilinx.com> wrote: > Hi guys, > > I have a question regarding to sharing generic OF pcie driver between > two architectures MB and ARM Zynq. > Is drivers/pci/pcie location good for it? > Make no sense to have the same driver in two locations.
I think you're talking about a PCI host bridge driver. It would definitely be nice to move toward a generic, shared driver. Host bridge drivers are responsible for enumerating the PCI hierarchy below the bridge. Enumeration is not really PCIe-specific, so I wouldn't put it in drivers/pci/pcie.
> Is using readl/writel IO functions in this driver the best option > which we can have? > Or is there any other recommendation?
I'm not really a driver person, but if you're writing a new driver, wouldn't you use the iomap interfaces (ioremap(), ioread32(), etc) rather than readl()?
> Also just want to check if it is correct to use pcie device_type.
I don't know what you're asking here. Can you elaborate or give a specific example?
> The rest should be the same with pci description: > (http://devicetree.org/MPC5200:PCI#PCI_Address_Translation).
| |