Messages in this thread | | | Date | Thu, 6 Dec 2012 18:54:39 +0000 | From | Matthew Garrett <> | Subject | Re: Use PCI ROMs from EFI boot services |
| |
On Thu, Dec 06, 2012 at 10:26:01AM -0800, H. Peter Anvin wrote:
> NAK on this bit: > > + if (boot_params.hdr.version < 0x0209) > + return 0; > > This field is kernel->bootloader documentation. If a nonmaching > value somehow leaks into the kernel, the kernel could either > panic("Bootloader written by moron") or it should clear some fields, > but littering the kernel with these kinds of tests is just plain > braindead.
Dropping that should be fine. Bjorn, would you prefer a patch from me to do that?
-- Matthew Garrett | mjg59@srcf.ucam.org
| |