lkml.org 
[lkml]   [2012]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: Use PCI ROMs from EFI boot services
    On Wed, Dec 5, 2012 at 5:52 PM, Yinghai Lu <yinghai@kernel.org> wrote:
    > On Wed, Dec 5, 2012 at 4:51 PM, Yinghai Lu <yinghai@kernel.org> wrote:
    >> On Wed, Dec 5, 2012 at 4:36 PM, H. Peter Anvin <hpa@zytor.com> wrote:
    >>> On 12/05/2012 04:15 PM, Yinghai Lu wrote:
    >>>>
    >>>
    >>> I don't see why that isn't the right fix. We copy the data into
    >>> boot_params early in the boot; that *is* the official copy as far as the
    >>> kernel is concerned.
    >>>
    >>> So this patch very much seems like The Right Thing.
    >>
    >> it moves boot_params from __initdata to data.
    >
    > should be from __initdata to bss
    >
    >> and just for using pointer to setup_data.
    >>
    >> should add setup_data pointer instead. so will not waste (4096 - 8) bytes.

    I'm not following the whole discussion here, but my impression is that
    what's in my -next branch is acceptable
    (http://git.kernel.org/?p=linux/kernel/git/helgaas/pci.git;a=commitdiff;h=328949ff10f2e3fcb11472571294beed39488342)

    If not, please explain further and provide a patch to fix it.

    Bjorn


    \
     
     \ /
      Last update: 2012-12-06 20:01    [W:3.650 / U:1.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site