Messages in this thread Patch in this message | | | From | Jan H. Schönherr <> | Subject | [PATCH v2 06/14] printk: move wake_klogd-check out of the loop | Date | Thu, 6 Dec 2012 18:06:03 +0100 |
| |
The checked criterion is loop-independent and we hold the lock necessary to do the check also outside the loop. So, move that piece of code more towards the end where the result is used.
Signed-off-by: Jan H. Schönherr <schnhrr@cs.tu-berlin.de> --- kernel/printk.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/printk.c b/kernel/printk.c index 7328348..4f3c355 100644 --- a/kernel/printk.c +++ b/kernel/printk.c @@ -2060,10 +2060,6 @@ again: int level; raw_spin_lock_irqsave(&logbuf_lock, flags); - if (seen_seq != log_next_seq) { - wake_klogd = true; - seen_seq = log_next_seq; - } if (console_seq < log_first_seq) { /* messages are gone, move to first one */ @@ -2124,6 +2120,10 @@ skip: */ raw_spin_lock(&logbuf_lock); retry = console_seq != log_next_seq; + if (seen_seq != log_next_seq) { + wake_klogd = true; + seen_seq = log_next_seq; + } raw_spin_unlock_irqrestore(&logbuf_lock, flags); if (retry && console_trylock()) -- 1.8.0.1.20.g7c65b2e.dirty -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |