Messages in this thread | | | Date | Thu, 6 Dec 2012 11:32:38 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH 1/1] iommuv2/amd: Enable Performance Counters On Family 15h Models 10h-1Fh |
| |
On Tue, Dec 04, 2012 at 04:19:06PM -0600, Steven Kinney wrote: > drivers/iommu/Kconfig | 10 +++++ > drivers/iommu/amd_iommu_init.c | 85 +++++++++++++++++++++++++++++++++++++++ > drivers/iommu/amd_iommu_types.h | 13 +++++- > 3 files changed, 107 insertions(+), 1 deletion(-)
So first of all, this patch alone doesn't make sense. You should submit it in a patch-set that enabled IOMMUv2 performance counters for the end-user. This means together with the PMU implementation and tools support.
Further I don't see how this patch is specific to Family 15h Models 10h-1Fh as described in the subject-line.
Any comments on these two points?
Cheers,
Joerg
| |