| Date | Wed, 5 Dec 2012 11:13:52 +0100 | From | Jean Delvare <> | Subject | Re: [PATCH 11/14] HID: i2c-hid: remove unneeded test in i2c_hid_remove |
| |
On Tue, 4 Dec 2012 16:27:52 +0100, Benjamin Tissoires wrote: > ihid can not be null, so there are no reasons to test it. > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com> > --- > drivers/hid/i2c-hid/i2c-hid.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c > index 4e3f80b..2b49929 100644 > --- a/drivers/hid/i2c-hid/i2c-hid.c > +++ b/drivers/hid/i2c-hid/i2c-hid.c > @@ -890,9 +890,6 @@ static int __devexit i2c_hid_remove(struct i2c_client *client) > struct i2c_hid *ihid = i2c_get_clientdata(client); > struct hid_device *hid; > > - if (WARN_ON(!ihid)) > - return -1; > - > hid = ihid->hid; > hid_destroy_device(hid); >
This leaves <linux/bug.h> included for no good reason. Please remove it too.
-- Jean Delvare
|