lkml.org 
[lkml]   [2012]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 09/14] HID: i2c-hid: i2c_hid_get_report may fail
    On Tue,  4 Dec 2012 16:27:50 +0100, Benjamin Tissoires wrote:
    > If i2c_hid_get_report fails, exit i2c_hid_init_report.
    > The printk log is already called by i2c_hid_get_report, so no need
    > to add some more printks.
    >
    > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
    > ---
    > drivers/hid/i2c-hid/i2c-hid.c | 5 +++--
    > 1 file changed, 3 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
    > index da04948..dcacfc4 100644
    > --- a/drivers/hid/i2c-hid/i2c-hid.c
    > +++ b/drivers/hid/i2c-hid/i2c-hid.c
    > @@ -400,9 +400,10 @@ static void i2c_hid_init_report(struct hid_report *report, u8 *buffer,
    > unsigned int size, ret_size;
    >
    > size = i2c_hid_get_report_length(report);
    > - i2c_hid_get_report(client,
    > + if (i2c_hid_get_report(client,
    > report->type == HID_FEATURE_REPORT ? 0x03 : 0x01,
    > - report->id, buffer, size);
    > + report->id, buffer, size))
    > + return;
    >
    > i2c_hid_dbg(ihid, "report (len=%d): %*ph\n", size, size, ihid->inbuf);
    >

    OK, although I don't quite get the rationale for not reporting the
    errors from i2c_hid_init_report() and i2c_hid_init_reports() to their
    respective callers. Does the device have any chance to work properly if
    i2c_hid_init_reports() fails?

    Reviewed-by: Jean Delvare <khali@linux-fr.org>

    --
    Jean Delvare


    \
     
     \ /
      Last update: 2012-12-05 11:42    [W:4.117 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site