Messages in this thread | | | From | "Yang, Wenyou" <> | Subject | RE: [v2 PATCH 2/8] watchdog/at91sam9_wdt: Convert to use the watchdog framework | Date | Thu, 6 Dec 2012 00:54:48 +0000 |
| |
Hi Florian,
> -----Original Message----- > From: Florian Fainelli [mailto:f.fainelli@gmail.com] On Behalf Of Florian Fainelli > Sent: 2012年12月5日 18:48 > To: Yang, Wenyou > Cc: linux-arm-kernel@lists.infradead.org; Ferre, Nicolas; plagnioj@jcrosoft.com; Lin, > JM; wim@iguana.be; linux-watchdog@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [v2 PATCH 2/8] watchdog/at91sam9_wdt: Convert to use the watchdog > framework > > Hello Wenyou, > > On Wednesday 05 December 2012 09:34:21 Wenyou Yang wrote: > > According to the kernel document: convert_drivers_to_kernel_api.txt, > > remove the file_operations struct, miscdevice, and obsolete includes > > > > Since the at91sam watchdog inherent characteristics, add the watchdog > > operations: at91wdt_start, at91wdt_stop and at91wdt_ping. > > > > [snip] > > > > > +static inline bool watchdog_is_open(struct watchdog_device *wddev) > > +{ > > + return test_bit(WDOG_DEV_OPEN, &wddev->status); > > +} > > This helper should be moved to include/linux/watchdog.h as it can be useful > for other watchdog drivers as well.
Thanks, I will move it in next version.
> -- > Florian
Best Regards Wenyou Yang
| |