Messages in this thread | | | Date | Wed, 05 Dec 2012 16:36:29 -0800 | From | "H. Peter Anvin" <> | Subject | Re: Use PCI ROMs from EFI boot services |
| |
On 12/05/2012 04:15 PM, Yinghai Lu wrote: > > -#ifndef CONFIG_DEBUG_BOOT_PARAMS > -struct boot_params __initdata boot_params; > -#else > struct boot_params boot_params; > -#endif
> > No, that is not a right fix > > We should only cache pointer to setup_data. > > at the same time we should export setup_data into /sys, so kexec could > append this pointer to command of > second kernel, just like kexec append acpi_rsdp. > That should address DavidW's concern. >
I don't see why that isn't the right fix. We copy the data into boot_params early in the boot; that *is* the official copy as far as the kernel is concerned.
So this patch very much seems like The Right Thing.
-hpa
| |