Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning | Date | Wed, 5 Dec 2012 22:04:50 +0000 |
| |
if (PageHWPoison(page) && !(flags & TTU_IGNORE_HWPOISON)) { - if (PageAnon(page)) + if (PageHuge(page)) + ; + else if (PageAnon(page)) dec_mm_counter(mm, MM_ANONPAGES); else dec_mm_counter(mm, MM_FILEPAGES);
This style minimizes the "diff" ... but wouldn't it be nicer to say:
if (!PageHuge(page)) { old code in here }
-Tony
| |