lkml.org 
[lkml]   [2012]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] perf hists: Link hist entries before inserting to an output tree
Em Wed, Dec 05, 2012 at 08:06:46PM +0100, Jiri Olsa escreveu:
> On Wed, Dec 05, 2012 at 03:56:42PM +0900, Namhyung Kim wrote:
> > From: Namhyung Kim <namhyung.kim@lge.com>
> > @@ -481,6 +459,11 @@ static void hists__process(struct hists *old, struct hists *new)
> > else
> > hists__link(new, old);
> >
> > + hists__output_resort(new);
> > +
> > + if (show_displacement)
> > + hists__compute_position(new);
> > +
>
> Computing the position after hists__link screws up the position data,
> because we likely have new entries in.
>
> However, I wonder if anyone is actualy using displacement info..?

IIRC that was used long ago in the first version of 'perf diff', that
is not the default, probably we can just ditch it to simplify things,
can you check?

- Arnaldo


\
 
 \ /
  Last update: 2012-12-05 21:01    [W:0.096 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site