| Date | Thu, 06 Dec 2012 00:42:10 +0530 | From | "Srivatsa S. Bhat" <> | Subject | Re: [RFC PATCH v2 10/10] cpu: No more __stop_machine() in _cpu_down() |
| |
On 12/06/2012 12:38 AM, Oleg Nesterov wrote: > On 12/06, Srivatsa S. Bhat wrote: >> >> @@ -418,7 +418,7 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen) >> } >> smpboot_park_threads(cpu); >> >> - err = __stop_machine(take_cpu_down, &tcd_param, cpumask_of(cpu)); >> + err = stop_cpus(cpumask_of(cpu), take_cpu_down, &tcd_param); > > stop_one_cpu(cpu) ? >
Even I was thinking of using that. Paul, any particular reason you chose stop_cpus() over stop_one_cpu() in [1]?
[1]. https://lkml.org/lkml/2012/10/30/359
Regards, Srivatsa S. Bhat
|