Messages in this thread | | | Date | Wed, 5 Dec 2012 17:11:40 +0000 | From | Alan Cox <> | Subject | Re: [PATCH RESEND] tty: don't dead lock while flushing workqueue |
| |
On Wed, 05 Dec 2012 17:15:40 +0100 Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> On 12/03/2012 06:41 PM, Peter Hurley wrote: > > The lock logic for tty_set_ldisc() is wrong. Despite existing code in > > tty_set_ldisc() and tty_ldisc_hangup(), the ldisc_mutex does **not** > > (and should not) play a role in acquiring or releasing ldisc references. > > The only thing that needs to happen here is below (don't actually use > > below because I just hand-edited it): > > Hmm. What about I stay in sync with the code that is already in tree > and if the wrong locking gets removed in both places later on? > > Alan, what do you prefer?
So long as it ends up right I don't care 8)
| |