[lkml]   [2012]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [PATCH v7 2/3] aerdrv: Enhanced AER logging
> > +	char *prefix = NULL;
> What are you doing here? You dropped the 'prefix' argument being passed
> down in this function and are defining a local variable of the same
> name
> which is used in the function later:
> printk("%s""aer_status: 0x%08x, aer_mask: 0x%08x\n",
> prefix, status, mask);


I removed the prefix argument because it was never used by its caller and never set. The reason I added the prefix variable and set it to NULL was to help in breaking up the patch and adding it would help the intermittent patch build without changing too much code. I knew I was actually going to use the variable in patch 3.


 \ /
  Last update: 2012-12-05 18:22    [W:0.095 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site