Messages in this thread | | | Date | Wed, 05 Dec 2012 12:05:57 +0100 | From | Michal Marek <> | Subject | Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source |
| |
Dne 5.12.2012 11:30, James Hogan napsal(a): > However I think it's unfortunate having to stringify from C as it's > pretty much always required to be in string form when used from a C > file, usually in an asm block. Any objection to defining SYMBOL_PREFIX > with the quotes around it for _c_flags only? E.g. see below
After Takashi's patch is applied, there will be no user of the SYMBOL_PREFIX in C source. But it would probably be more convenient for potential new users.
> +_c_sym_flags = -DSYMBOL_PREFIX=\"$(patsubst "%",%,$(CONFIG_SYMBOL_PREFIX))\"
Maybe simply
-DDSYMBOL_PREFIX='$(or $(CONFIG_SYMBOL_PREFIX),"")'
? The single quotes are needed either way, to prevent the shell eating the double quotes.
Michal
| |