Messages in this thread Patch in this message | | | From | "Srivatsa S. Bhat" <> | Subject | [RFC PATCH 05/10] kick_process(), cpu-hotplug: Prevent offlining of target CPU properly | Date | Tue, 04 Dec 2012 14:25:06 +0530 |
| |
With stop_machine() gone from the CPU offline path, we can't depend on preempt_disable() to prevent CPUs from going offline from under us.
Use the get/put_online_cpus_stable_atomic() APIs to prevent CPUs from going offline, while invoking from atomic context.
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> ---
kernel/sched/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index ef6ada4..c1a5d93 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -1091,11 +1091,11 @@ void kick_process(struct task_struct *p) { int cpu; - preempt_disable(); + get_online_cpus_stable_atomic(); cpu = task_cpu(p); if ((cpu != smp_processor_id()) && task_curr(p)) smp_send_reschedule(cpu); - preempt_enable(); + put_online_cpus_stable_atomic(); } EXPORT_SYMBOL_GPL(kick_process); #endif /* CONFIG_SMP */
| |