Messages in this thread | | | Date | Wed, 5 Dec 2012 08:35:00 +0530 | Subject | Re: [PATCH RFC] PM/Devfreq: Add Exynos5-bus devfreq driver for Exynos5250. | From | Abhilash Kesavan <> |
| |
Cc'ing missed out recipients
---------- Forwarded message ---------- From: Abhilash Kesavan <kesavan.abhilash@gmail.com> Date: Tue, Dec 4, 2012 at 9:48 PM Subject: Re: [PATCH RFC] PM/Devfreq: Add Exynos5-bus devfreq driver for Exynos5250. To: linux-pm@vger.kernel.org
Jonghwan Choi <jhbird.choi <at> samsung.com> writes:
> > > Hi Abhilash Kesavan. Hi, > > I compiled in 3.7-rc8 > I got a compile error & warning. > > Compile error. > > CC drivers/devfreq/exynos5_ppmu.o > drivers/devfreq/exynos5_ppmu.c:56:14: error: 'S5P_VA_PPMU_DDR_C' undeclared > here (not in a function) > drivers/devfreq/exynos5_ppmu.c:59:14: error: 'S5P_VA_PPMU_DDR_R1' undeclared > here (not in a function) > drivers/devfreq/exynos5_ppmu.c:62:13: error: 'S5P_VA_PPMU_DDR_L' undeclared > here (not in a function) > drivers/devfreq/exynos5_ppmu.c:65:13: error: 'S5P_VA_PPMU_RIGHT' undeclared > here (not in a function) > drivers/devfreq/exynos5_ppmu.c:68:14: error: 'S5P_VA_PPMU_CPU' undeclared > here (not in a function) > make[2]: *** [drivers/devfreq/exynos5_ppmu.o] Error 1 I have submitted only the driver changes. As mentioned in the commit message I will post the arch side changes after the drivers gets a complete review. However, if you want to test the driver I will post it tommorrow.
[...] > drivers/devfreq/exynos5_bus.c: In function 'exynos5_busfreq_int_probe': > drivers/devfreq/exynos5_bus.c:388:9: warning: passing argument 3 of > 'devfreq_add_device' from incompatible pointer type [enabled by default] > include/linux/devfreq.h:170:24: note: expected 'struct devfreq_governor > const *' but argument is of type 'char *' [...] > Need change? These changes are based on git://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git : for-rafael devfreq_add_device prototype has recently changed and that might be the cause of the compilation error. Can you please try on this tree.
> How to change the INT clock? I think you have to change > arch/arm/mach-exynos/clock-exynos5250.c > (If you want to control via clock framework.) [...] > exynos5_int_clk.ops = &exynos5_clk_int_ops; This is part of the arch side patch that has not been posted.
Regards, Abhilash
-- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
| |