lkml.org 
[lkml]   [2012]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC][PATCH 1/2] modsig: add support to sign kernel modules using ephemeral keys
Date
Rusty Russell <rusty@rustcorp.com.au> wrote:

> > +PHONY += _newmodpubkey_
> > +_newmodpubkey_:
> > + @rm -f $(MODSECKEY) $(MODPUBKEY)
> > + $(Q)$(MAKE) -W kernel/modsign_pubkey.o

Please don't do this. It can muck up the dependencies as make thinks it has
already done this file at this point. Also, rebuilding bzImage yet again
wouldn't be the best. We already do it a number of times. Further, if
vmlinux is already installed when you rebuild, you may confuse gdb if the
debuginfo then no longer matches vmlinux.

You have to expose the private key *anyway* - so how much does this actually
gain you? Especially with a one-shot transient key.

David


\
 
 \ /
  Last update: 2012-12-04 19:41    [W:0.104 / U:1.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site