Messages in this thread | | | Date | Tue, 4 Dec 2012 20:16:27 +0530 | From | Santosh Shilimkar <> | Subject | Re: [PATCH] memory: of_memory.c: remove unnecessary initialization |
| |
On Tuesday 04 December 2012 07:25 PM, Grant Likely wrote: > On Tue, Dec 4, 2012 at 11:44 AM, Santosh Shilimkar > <santosh.shilimkar@ti.com> wrote: >> On Tuesday 04 December 2012 04:56 PM, Cong Ding wrote: >>> >>> the initialization of variable ret is unnecessary, we can remove it while >>> save >>> one time "or" operation. >>> >>> Signed-off-by: Cong Ding <dinggnu@gmail.com> >>> --- >> >> Looks ok. >> Acked-by: Santosh Shilimkar<santosh.shilimkar@ti.com> >> > > Thanks for the patch, but I don't think it matters enough to apply it. > The existing code isn't wrong. > The patch was removing an additional operation and hence i didn't contest it. I agree with your comment though.
Regards Santosh
| |