lkml.org 
[lkml]   [2012]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net/macb: Use dmapool to align descriptors on 64bits
On 12/03/2012 03:01 PM, Ben Hutchings :
> On Mon, 2012-12-03 at 13:15 +0100, Nicolas Ferre wrote:
>> Depending on datapath, some revisions of GEM need
>> 64bits aligned descriptors. Use dmapool to allocate
>> these descriptors.
>> Note that different size between RX and TX rings
>> leads to the creation of two pools.
>>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> [...]
>
> dma_alloc_coherent() allocates whole pages, which I think is quite
> enough alignment. You can't save memory by doing this, since each pool
> needs at least one page. So what is this change meant to achieve?

Well... I guess we can forget this patch then ;-)

Thanks, best regards,
--
Nicolas Ferre


\
 
 \ /
  Last update: 2012-12-04 18:21    [W:0.043 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site