Messages in this thread | | | Date | Tue, 4 Dec 2012 12:16:29 +0530 | From | Santosh Shilimkar <> | Subject | Re: [linux-keystone] [PATCH v2] drivers: cma: fix addressing on PAE machines |
| |
On Monday 03 December 2012 09:16 PM, Vitaly Andrianov wrote: > This patch fixes a couple of bugs that otherwise impair CMA functionality on > PAE machines: > > - alignment must be a 64-bit type when running on systems with 64-bit > physical addresses. If this is not the case, the limit calculation thunks > allocations down to an address range < 4G. > > - The allocated range check is removed. On 32bit ARM kernel with LPAE > enabled the base may be allocated outside the fist 4GB of physical > memory (keystone SoC for example). > Any reason you have clubbed two fixes in one patch. Its better to keep the two fixes separate patches.
> Signed-off-by: Vitaly Andrianov <vitalya@ti.com> > Signed-off-by: Cyril Chemparathy <cyril@ti.com> > --- Other than that, patch looks good to my eyes.
Regards, Santosh
| |