lkml.org 
[lkml]   [2012]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/3] perf diff: Use internal rb tree for compute resort
Date
On Tue, 4 Dec 2012 10:45:44 -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Dec 04, 2012 at 01:44:25PM +0900, Namhyung Kim escreveu:
>> From: Namhyung Kim <namhyung.kim@lge.com>
>>
>> There's no reason to run hists_compute_resort() using output tree.
>> Convert it to use internal tree so that it can remove unnecessary
>> _output_resort. Also move position computation below the resort since
>> it changes the output ordering.
>
> Have you tested this with 'perf top'? With the highest frequency?

After testing 'perf top -F 100000' couple of minutes, I couldn't find
any visible problem. Basically this patchset changes hists__link/match
path which only called from 'perf diff' - I'm working on making use of
that for event group report though. So I didn't check perf top side
seriously. Any reason do you mention it that I'm missing?

Thanks,
Namhyung


\
 
 \ /
  Last update: 2012-12-04 17:41    [W:0.038 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site