Messages in this thread | | | Date | Tue, 4 Dec 2012 07:57:39 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH] megaraid: fix use of delayed work |
| |
Hello, again, Xiaotian.
On Tue, Dec 04, 2012 at 07:39:39AM -0800, Tejun Heo wrote: > Urgh... what the.... Didn't see that one coming. I'm gonna push this > to Linus through the workqueue tree. > > Thanks for the fix.
It seems like megaraid doesn't have any reason to use delayed_work at all. It can use a plain work and cancel_work_sync() instead. Maybe it was doing the container_of() thing because workqueue didn't use to have cancel_work_sync()? Anyways, please convert it to use plain work_struct post 3.7.
Thanks.
-- tejun
| |