lkml.org 
[lkml]   [2012]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging:iio:adis16260: select IIO_ADIS_LIB to fix build error
On 12/31/2012 06:36 AM, Yuanhan Liu wrote:
> Commit 9d5e9fdf turned the code to use adis library, so it depends on
> adis lib. But it forgot to select it at Kconfig file. Thus if adis is
> not enabled, it will produce following build errros(catched by Fengguang's
> 0-DAY kernel build testing system):
> ERROR: "adis_initial_startup" [drivers/staging/iio/gyro/adis16260.ko] undefined!
> ERROR: "adis_init" [drivers/staging/iio/gyro/adis16260.ko] undefined!
> ERROR: "adis_write_reg" [drivers/staging/iio/gyro/adis16260.ko] undefined!
> ERROR: "adis_read_reg" [drivers/staging/iio/gyro/adis16260.ko] undefined!
> ERROR: "adis_single_conversion" [drivers/staging/iio/gyro/adis16260.ko] undefined!
>
> Selecting IIO_ADIS_LIB at Kconfig file fixes this issue.
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

Hi,

Thanks. But I already sent a similar patch some time ago. See
http://www.spinics.net/lists/linux-iio/msg07128.html

- Lars

> ---
> drivers/staging/iio/gyro/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/iio/gyro/Kconfig b/drivers/staging/iio/gyro/Kconfig
> index ea295b2..476207a 100644
> --- a/drivers/staging/iio/gyro/Kconfig
> +++ b/drivers/staging/iio/gyro/Kconfig
> @@ -27,6 +27,7 @@ config ADIS16130
> config ADIS16260
> tristate "Analog Devices ADIS16260 Digital Gyroscope Sensor SPI driver"
> depends on SPI
> + select IIO_ADIS_LIB
> select IIO_TRIGGER if IIO_BUFFER
> select IIO_SW_RING if IIO_BUFFER
> help



\
 
 \ /
  Last update: 2012-12-31 09:01    [W:0.037 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site