Messages in this thread Patch in this message | | | Date | Tue, 01 Jan 2013 13:58:16 +1100 | From | Nigel Cunningham <> | Subject | [PATCH 2] Re: New Defect(s) reported by Coverity Scan |
| |
From 68e866b8eac534405ae16b79b7ffd9de05c11c67 Mon Sep 17 00:00:00 2001 From: Nigel Cunningham <nigel@nigelcunningham.com.au> Date: Tue, 1 Jan 2013 13:50:22 +1100 Subject: [PATCH] Fix uninitialised variable in rbd_dev_probe_update_spec.
The local variable ret can be used uninitialised in the error path if the kstrdup at line 2631 fails. Set ret to -ENOMEM in that case.
This patch addresses Coverity #753111.
Signed-off-by: Nigel Cunningham <nigel@nigelcunningham.com.au> --- drivers/block/rbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index dfb7ef8..ba4dd66 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -2629,8 +2629,10 @@ static int rbd_dev_probe_update_spec(struct rbd_device *rbd_dev) goto out_err; } rbd_dev->spec->snap_name = kstrdup(name, GFP_KERNEL); - if(!rbd_dev->spec->snap_name) + if(!rbd_dev->spec->snap_name) { + ret = -ENOMEM; goto out_err; + }
return 0; out_err: -- 1.7.10.4
| |