Messages in this thread | | | Date | Mon, 31 Dec 2012 15:45:31 +0100 | Subject | Re: [PATCH] printk: Fix incorrect length from print_time() when seconds > 99999 | From | Sylvain Munaut <> |
| |
Hi,
>> Sylvan Munaut did something similar >> https://lkml.org/lkml/2012/12/5/168 > > Missed that and duplicated the debugging :( > Sorry Sylvain.
I should have followed up on the patch sooner, but I basically finished testing it fixed all the issues and posted it just before leaving for vacation and I just got back (and didn't check my work email there).
> I guess my patch may be preferable, since I happened to use the snprintf() > method that you suggest -- all the open-coded digit-counting seems a bit > verbose and perhaps hard to read and see the equivalence to the sprintf.
Yes, I just did it that way to match the way if was done in other parts of that file in ... the snprintf method is clearly more readable.
Cheers,
Sylvain
| |