Messages in this thread | | | Subject | Re: [PATCH v4 1/3] aerdrv: Trace Event for AER | From | Joe Perches <> | Date | Mon, 03 Dec 2012 12:26:33 -0800 |
| |
On Mon, 2012-12-03 at 20:20 +0000, Ortiz, Lance E wrote: > > > +#define correctable_error_string \ > > > + {BIT(0), "Receiver Error"}, \ > > > + {BIT(6), "Bad TLP"}, \ > > > + {BIT(7), "Bad DLLP"}, \ > > > + {BIT(8), "RELAY_NUM Rollover"}, \ > > > + {BIT(12), "Replay Timer Timeout"}, \ > > > + {BIT(13), "Advisory Non-Fatal"} > > > + > > > +#define uncorrectable_error_string \ > > > + {BIT(4), "Data Link Protocol"}, \ > > > + {BIT(12), "Poisoned TLP"}, \ > > > + {BIT(13), "Flow Control Protocol"}, \ > > > + {BIT(14), "Completion Timeout"}, \ > > > + {BIT(15), "Completer Abort"}, \ > > > + {BIT(16), "Unexpected Completion"}, \ > > > + {BIT(17), "Receiver Overflow"}, \ > > > + {BIT(18), "Malformed TLP"}, \ > > > + {BIT(19), "ECRC"}, \ > > > + {BIT(20), "Unsupported Request"} > > > > probably better to prefix these with aer_ > > If I add aer_ it will conflict with string array in aerdrv_errprint.c
Maybe just not something quite so generic. maybe aer_trace_correctable and aer_trace_uncorrectable
cheers, Joe
| |