Messages in this thread | | | From | "Ortiz, Lance E" <> | Subject | RE: [PATCH v4 1/3] aerdrv: Trace Event for AER | Date | Mon, 3 Dec 2012 20:20:22 +0000 |
| |
> > +#define correctable_error_string \ > > + {BIT(0), "Receiver Error"}, \ > > + {BIT(6), "Bad TLP"}, \ > > + {BIT(7), "Bad DLLP"}, \ > > + {BIT(8), "RELAY_NUM Rollover"}, \ > > + {BIT(12), "Replay Timer Timeout"}, \ > > + {BIT(13), "Advisory Non-Fatal"} > > + > > +#define uncorrectable_error_string \ > > + {BIT(4), "Data Link Protocol"}, \ > > + {BIT(12), "Poisoned TLP"}, \ > > + {BIT(13), "Flow Control Protocol"}, \ > > + {BIT(14), "Completion Timeout"}, \ > > + {BIT(15), "Completer Abort"}, \ > > + {BIT(16), "Unexpected Completion"}, \ > > + {BIT(17), "Receiver Overflow"}, \ > > + {BIT(18), "Malformed TLP"}, \ > > + {BIT(19), "ECRC"}, \ > > + {BIT(20), "Unsupported Request"} > > probably better to prefix these with aer_
If I add aer_ it will conflict with string array in aerdrv_errprint.c
> > > + TP_printk("%s PCIe Bus Error: severity=%s, %s\n", > > + __get_str(dev_name), > > + (__entry->severity == HW_EVENT_ERR_CORRECTED) ? "Corrected" > : > > + ((__entry->severity == HW_EVENT_ERR_FATAL) ? > > + "Fatal" : "Uncorrected"), > > unnecessary parentheses > > __entry->severity == HW_EVENT_ERR_CORRECTED ? "Corrected" : > __entry->severity == HW_EVENT_ERR_FATAL ? "Fatal" : > "Uncorrected"), > > might be more kernel style conventional
Ok I removed them.
Thanks
Lance
| |