lkml.org 
[lkml]   [2012]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] device_cgroup: keep track of local group settings
On Mon, Dec 03, 2012 at 06:01:25PM +0000, Serge E. Hallyn wrote:
> First, generally, I don't think 'allows' added to parent should be
> automatically propagated to descendents.

that's what I think too and what I tried to do

> In devcgroup_update_access: (around line 625)
> there is a period of time where cgroup members have
> default allow without the parent's exceptions.

true, will fix that one and look for more cases

> propagate_behavior (line 505):
> 1. doesn't follow the same ordering as devcgroup_update_access(), in
> particular cleaning exceptions before setting behavior.

I see, will update that

> 2. When changing a parent from deny to allow, I don't think children
> should be updated.

I disagree on this one. since there'll be local preferences, it'll try
to revalidate them everytime there's a change. so, for example, an
exception that might not be possible now, will be possible when its
parent changes in a way that allows that.

--
Aristeu



\
 
 \ /
  Last update: 2012-12-03 20:41    [W:0.148 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site