lkml.org 
[lkml]   [2012]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] scripts/tags.sh: Support compiled source
From
2012/12/4 Michal Marek <mmarek@suse.cz>:
> On 3.12.2012 17:22, Joonsoo Kim wrote:
>> We usually have interst in compiled files only,
>> because they are strongly related to individual's work.
>> Current tags.sh can't select compiled files, so support it.
>>
>> We can use this functionality like below.
>> "make cscope O=. SRCARCH=xxxx SUBARCH=compiled"
>
> I like the idea, but please try to come up with a different syntax that
> does not abuse SUBARCH.
>
>
>> +all_compiled_sources()
>> +{
>> + for i in $(all_sources); do
>> + if [[ $i =~ .*c$ || $i =~ .*S$ ]]; then
>> + j=${i/\.[cS]/\.o}
>
> Please use 'case "$i" in ...' instead of the bash-specific [[ ... ]]
> construct.

I send v2 which is fixed according to your comment.
Thanks for review.


\
 
 \ /
  Last update: 2012-12-03 19:41    [W:5.804 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site