Messages in this thread | | | Date | Mon, 3 Dec 2012 16:57:36 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 12/18] perf ui/hist: Add support for event group view |
| |
On Mon, Dec 03, 2012 at 07:39:31PM +0900, Namhyung Kim wrote: > On Mon, 3 Dec 2012 11:23:27 +0100, Jiri Olsa wrote: > > On Mon, Dec 03, 2012 at 10:56:28AM +0900, Namhyung Kim wrote: > >> On Fri, Nov 30, 2012 at 10:29 PM, Jiri Olsa <jolsa@redhat.com> wrote: > >> > ok, so this is the part thats common for both multi diff and group > >> > report and hugely depends on how we link matching hist_entry
SNIP
> > we discussed with Arnaldo and decided to stay with current approach and > > make the change later if needed.. to be able to see/meassure the benefit > > > > I made some initial attempt to workaround this and it appears to be > > not that bad ;) I'll repost my changes shortly.. > > Hmm.. so are you OK with this patch now?
yep, well except for following macros:
__HPP_COLOR_PERCENT_FN __HPP_ENTRY_PERCENT_FN __HPP_ENTRY_RAW_FN
being so long.. any chance the main part of it being in function?
Seems like '_type' is just in function name, but the '_field' might be the killer ;) maybe it could be 'used' in such function via PERF_HPP__* enums instead..?
thanks, jirka
| |