lkml.org 
[lkml]   [2012]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info
On Mon, Dec 03, 2012 at 01:15:01PM +0800, Jason Wang wrote:
> > > +
>
> > > + /* Work struct for refilling if we run low on memory. */
>
> > > + struct delayed_work refill;
>
> >
>
> > I can't really see the justificaiton for a refill per queue. Just have
>
> > one work iterate all the queues if it happens, unless it happens often
>
> > (in which case, we need to look harder at this anyway).
>
>
>
> But during this kind of iteration, we may need enable/disable the napi
> regardless of whether the receive queue has lots to be refilled. This may add
> extra latency.

We are running from the timer, so latency is not a concern I think.

--
MST


\
 
 \ /
  Last update: 2012-12-03 12:41    [W:0.060 / U:1.964 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site