Messages in this thread | | | Date | Sat, 29 Dec 2012 21:29:02 -0500 | From | Theodore Ts'o <> | Subject | Re: [PATCH] xfs: return -EINVAL instead of -EUCLEAN when mounting non-xfs |
| |
On Sat, Dec 29, 2012 at 05:32:12PM -0600, Eric Sandeen wrote: > yeah, that should work; great minds think alike ;) Our patches > crossed in the ether I guess. > > XFS uses EWRONGFS as an alias for EINVAL internally in these cases, > so maybe we should stick with that for consistency, *shrug*
I keep thinking we should try expanding the number of errno's so that the file system can give more fs-specific error codes, such that eventually, user programs could print out error messages that would make a lot more sense to users. What we'd have to do is to define the new errno's, and then wait for the new error_message() strings to propagate out to a new glibc release, and only then have the kernel start using the new errno values. It would be a pain in the tuckus to do, but in the long run the end result would be a lot better for end users and system administrators.
- Ted
| |