lkml.org 
[lkml]   [2012]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 11/27] sched: Comment on rq->clock correctness in ttwu_do_wakeup() in nohz
    Date
    Just to avoid confusion.

    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Alessio Igor Bogani <abogani@kernel.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Chris Metcalf <cmetcalf@tilera.com>
    Cc: Christoph Lameter <cl@linux.com>
    Cc: Geoff Levand <geoff@infradead.org>
    Cc: Gilad Ben Yossef <gilad@benyossef.com>
    Cc: Hakan Akkan <hakanakkan@gmail.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    ---
    kernel/sched/core.c | 6 ++++++
    1 files changed, 6 insertions(+), 0 deletions(-)

    diff --git a/kernel/sched/core.c b/kernel/sched/core.c
    index 63b25e2..bfac40f 100644
    --- a/kernel/sched/core.c
    +++ b/kernel/sched/core.c
    @@ -1302,6 +1302,12 @@ ttwu_do_wakeup(struct rq *rq, struct task_struct *p, int wake_flags)
    if (p->sched_class->task_woken)
    p->sched_class->task_woken(rq, p);

    + /*
    + * For adaptive nohz case: We called ttwu_activate()
    + * which just updated the rq clock. There is an
    + * exception with p->on_rq != 0 but in this case
    + * we are not idle and rq->idle_stamp == 0
    + */
    if (rq->idle_stamp) {
    u64 delta = rq->clock - rq->idle_stamp;
    u64 max = 2*sysctl_sched_migration_cost;
    --
    1.7.5.4


    \
     
     \ /
      Last update: 2012-12-29 18:41    [W:2.284 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site