lkml.org 
[lkml]   [2012]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2] output the cpu number when printking.
Date
Thanks, Greg.
I did use this patch to fix many races on SMP. But to respect maintainer, I stop pushing the patch to upstream.


-----Original Message-----
From: Greg KH [mailto:gregkh@linuxfoundation.org]
Sent: Thursday, December 27, 2012 1:50 AM
To: Yanmin Zhang
Cc: He, Bo; Randy Dunlap; akpm@linux-foundation.org; mingo@elte.hu; linux-kernel@vger.kernel.org; a.p.zijlstra@chello.nl
Subject: Re: [PATCH V2] output the cpu number when printking.

On Tue, Dec 25, 2012 at 09:09:05AM +0800, Yanmin Zhang wrote:
> On Mon, 2012-12-24 at 09:55 -0800, Greg KH wrote:
> > On Mon, Dec 24, 2012 at 01:01:55PM +0800, he, bo wrote:
> > > From: "he, bo" <bo.he@intel.com>
> > >
> > > We often hit kernel panic issues on SMP machines because processes
> > > race on multiple cpu. By adding a new parameter printk.cpu, kernel
> > > prints cpu number at printk information line. It’s useful to debug
> > > what cpus are racing.
> >
> > How useful is this really for normal developers?
> It's very useful to debug race conditions under SMP environment.
> We applied the patch to our Android build image on our smartphones.

That's fine for your application, and seemed to be useful to others with their first interactions with SMP systems. However, once you start to get to "real" numbers of CPUs, this information turns pretty pointless, which is why the patch was originally rejected.

sorry,

greg k-h
\
 
 \ /
  Last update: 2012-12-27 08:41    [W:0.045 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site