lkml.org 
[lkml]   [2012]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers/platform/x86/thinkpad_acpi.c: Handle HKEY event 0x6040
On Wed, 26 Dec 2012, Richard Hartmann wrote:
> + case TP_HKEY_EV_AC_CHANGED:
> + pr_info("AC status has changed\n");
> + /* X120e, x121e, X220, X220i, X220t, X230, T420, T420s, W520:
> + * AC status changed; can be triggered by plugging or
> + * unplugging AC adapter, docking or undocking, or closing
> + * or opening the lid. */
> + break;
>
> case TP_HKEY_EV_KEY_NUMLOCK:
> case TP_HKEY_EV_KEY_FN:

I guess we can drop that pr_info, and please block the issuing of the
event to userspace, like this:

case TP_HKEY_EV_AC_CHANGED:
/* X120e, x121e, X220, X220i, X220t, X230, T420, T420s, W520:
* AC status changed; can be triggered by plugging or
* unplugging AC adapter, docking or undocking, or closing
* or opening the lid. */

/* fallthrough */

and letting it proceed to the TP_HKEY_EV_KEY_NUMLOCK block.

Also, do we have any confirmed reports about the lid switch
causing event 0x6040? It doesn't look right... the comment
might need to be updated.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh


\
 
 \ /
  Last update: 2012-12-27 12:21    [W:0.045 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site