Messages in this thread | | | Date | Thu, 27 Dec 2012 13:32:09 -0800 (PST) | Subject | Re: [PATCH] forcedeth: Fix WARNINGS that result when DMA mapping is not checked | From | David Miller <> |
| |
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Thu, 27 Dec 2012 13:03:29 -0800
> On Thu, 2012-12-27 at 14:38 -0600, Larry Finger wrote: >> On 12/27/2012 02:05 PM, Eric Dumazet wrote: >> > On Thu, 2012-12-27 at 13:42 -0600, Larry Finger wrote: > >> >> + if (pci_dma_mapping_error(np->pci_dev, >> >> + np->put_tx_ctx->dma)) >> >> + return NETDEV_TX_BUSY; >> > >> > Really this is not going to work very well : caller will call this in a >> > loop. >> >> Any suggestions on what value should be returned, or does the caller need to be >> modified? > > NETDEV_TX_BUSY is really obsolete > > Documentation/networking/driver.txt > > In case of mapping error, I would drop the packet.
Agreed.
| |