Messages in this thread Patch in this message | | | Date | Wed, 26 Dec 2012 22:49:40 +0100 (CET) | From | Jesper Juhl <> | Subject | [PATCH] netfilter: Don't leak 'exp' in ctnetlink_create_expect() |
| |
'if ((!help) && (!cda[CTA_EXPECT_TIMEOUT]))' then we should remember to free 'exp' that was allocated by 'nf_ct_expect_alloc()' by jumping to the 'err_out' label rather than the 'out' label in ctnetlink_create_expect(). This patch should get rid of the leak.
Signed-off-by: Jesper Juhl <jj@chaosbits.net> --- net/netfilter/nf_conntrack_netlink.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
note: compile tested only.
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index 4e078cd..627b0e5 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c @@ -2624,7 +2624,7 @@ ctnetlink_create_expect(struct net *net, u16 zone, if (!help) { if (!cda[CTA_EXPECT_TIMEOUT]) { err = -EINVAL; - goto out; + goto err_out; } exp->timeout.expires = jiffies + ntohl(nla_get_be32(cda[CTA_EXPECT_TIMEOUT])) * HZ; -- 1.7.1
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please.
| |