lkml.org 
[lkml]   [2012]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] USB: ehci-s5p: Add to get interrupt from DT
Hello.

On 12/26/2012 09:42 PM, Dongjin Kim wrote:

> This patch support to get interrupt resource from device tree as well as
> platform device if ehci node is defined in device tree and it's irq is
> described.

> Signed-off-by: Dongjin Kim <tobetter@gmail.com>
> ---
> drivers/usb/host/ehci-s5p.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)

> diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
> index 319dcfa..0fc5e5e 100644
> --- a/drivers/usb/host/ehci-s5p.c
> +++ b/drivers/usb/host/ehci-s5p.c
> @@ -16,6 +16,7 @@
> #include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/of_gpio.h>
> +#include <linux/of_irq.h>
> #include <linux/platform_data/usb-ehci-s5p.h>
> #include <plat/usb-phy.h>
>
> @@ -156,7 +157,12 @@ static int s5p_ehci_probe(struct platform_device *pdev)
> goto fail_io;
> }
>
> - irq = platform_get_irq(pdev, 0);
> + if (pdev->dev.of_node)
> + irq = irq_of_parse_and_map(pdev->dev.of_node, 0);

platform_get_irq() should still work for device tree based platform devices.
I don't see the point on the patch?

> + else {
> + irq = platform_get_irq(pdev, 0);
> + }

Hm, why {} out of the blue? Both arms of *if* are single-stratement.

> +

No need for empty line here.

> if (!irq) {
> dev_err(&pdev->dev, "Failed to get IRQ\n");
> err = -ENODEV;

WBR, Sergei



\
 
 \ /
  Last update: 2012-12-26 20:41    [W:0.041 / U:0.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site