Messages in this thread | | | Date | Wed, 26 Dec 2012 18:20:11 +0800 | From | Li Zefan <> | Subject | Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach() |
| |
On 2012/11/29 5:34, Tejun Heo wrote: > cpuset_can_attach() prepare global variables cpus_attach and > cpuset_attach_nodemask_{to|from} which are used by cpuset_attach(). > There is no reason to prepare in cpuset_can_attach(). The same > information can be accessed from cpuset_attach(). > > Move the prepartion logic from cpuset_can_attach() to cpuset_attach() > and make the global variables static ones inside cpuset_attach(). > > While at it, convert cpus_attach to cpumask_t from cpumask_var_t. > There's no reason to mess with dynamic allocation on a static buffer. >
But Rusty had been deprecating the use of cpumask_t. I don't know why the final deprecation hasn't been completed yet.
| |