Messages in this thread | | | Date | Wed, 26 Dec 2012 15:31:41 -0800 | From | Kent Overstreet <> | Subject | Re: [PATCH 04/26] aio: remove retry-based AIO |
| |
On Wed, Dec 19, 2012 at 08:04:11PM +0800, Hillf Danton wrote: > >@@ -52,15 +46,6 @@ struct kioctx; > > * not ask the method again -- ki_retry must ensure forward progress. > > * aio_complete() must be called once and only once in the future, multiple > > * calls may result in undefined behaviour. > >- * > >- * If ki_retry returns -EIOCBRETRY it has made a promise that kick_iocb() > >- * will be called on the kiocb pointer in the future. This may happen > >- * through generic helpers that associate kiocb->ki_wait with a wait > >- * queue head that ki_retry uses via current->io_wait. It can also happen > >- * with custom tracking and manual calls to kick_iocb(), though that is > >- * discouraged. In either case, kick_iocb() must be called once and only > >- * once. ki_retry must ensure forward progress, the AIO core will wait > >- * indefinitely for kick_iocb() to be called. > > */ > > struct kiocb { > > struct list_head ki_run_list; > > Then you can also erase ki_run_list if no longer used.
Thanks, fixed that and also the comments you pointed out.
| |