lkml.org 
[lkml]   [2012]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH BUGFIX] pkt_sched: fix little service anomalies and possible crashes of qfq+
From
From: Paolo valente <paolo.valente@unimore.it>
Date: Wed, 19 Dec 2012 18:31:06 +0100

> + /*
> + * The next assignment may let
> + * agg->initial_budget > agg->budgetmax
> + * hold, but this does not cause any harm
> + */

Please format comments in the networking:

/* Like
* this.
*/

and

/*
* Never
* like this.
*/

I know this file is full of exceptions, but that error is to be
corrected rather than expanded.

> + /*
> + * If lmax is lowered, through qfq_change_class, for a class
> + * owning pending packets with larger size than the new value of lmax,
> + * then the following condition may hold.
> + */

Likewise.

And I'm not applying this until someone familiar with this code
does some review of this patch. These are seriously non-trivial
changes.


\
 
 \ /
  Last update: 2012-12-27 00:41    [W:0.115 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site