Messages in this thread Patch in this message | | | Date | Tue, 25 Dec 2012 17:23:39 +0100 | From | Thomas Jarosch <> | Subject | [perf PATCH] Fix possible (unlikely) buffer overflow |
| |
cppcheck reported: [tools/perf/util/sysfs.c:50]: (error) Width 4096 given in format string (no. 1) is larger than destination buffer 'sysfs_mountpoint[4096]', use %4095s to prevent overflowing it
-> All other places in the kernel that use STR(PATH_MAX) have a buffer size of PATH_MAX+1.
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com> --- tools/perf/util/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/sysfs.c b/tools/perf/util/sysfs.c index 48c6902..606f884 100644 --- a/tools/perf/util/sysfs.c +++ b/tools/perf/util/sysfs.c @@ -8,7 +8,7 @@ static const char * const sysfs_known_mountpoints[] = { }; static int sysfs_found; -char sysfs_mountpoint[PATH_MAX]; +char sysfs_mountpoint[PATH_MAX+1]; static int sysfs_valid_mountpoint(const char *sysfs) { -- 1.7.11.7
| |